more crashes

[fluxionary]

supposedly the two following are when clicking "reply" and "reply all" with no message selected, but i can't replicate the issue:

2023-04-25 21:22:02: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.6.1/Minetest_test/bin/../mods/mail_mod/ui/message.lua:53: attempt to index local 'message' (a nil value)
2023-04-25 21:22:02: ERROR[Main]: stack traceback:
2023-04-25 21:22:02: ERROR[Main]: 	.../5.6.1/Minetest_test/bin/../mods/mail_mod/ui/message.lua:53: in function 'replyall'
2023-04-25 21:22:02: ERROR[Main]: 	...t/5.6.1/Minetest_test/bin/../mods/mail_mod/ui/events.lua:207: in function 'func'
2023-04-25 21:22:02: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100>
2023-04-25 21:22:02: ERROR[Main]: 	.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:432: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:418>

2023-04-25 21:45:06: ERROR[Main]: ServerError: AsyncErr: Lua: Runtime error from mod 'mail' in callback on_playerReceiveFields(): .../5.6.1/Minetest_test/bin/../mods/mail_mod/ui/message.lua:48: attempt to index local 'message' (a nil value)
2023-04-25 21:45:06: ERROR[Main]: stack traceback:
2023-04-25 21:45:06: ERROR[Main]: 	.../5.6.1/Minetest_test/bin/../mods/mail_mod/ui/message.lua:48: in function 'reply'
2023-04-25 21:45:06: ERROR[Main]: 	...t/5.6.1/Minetest_test/bin/../mods/mail_mod/ui/events.lua:198: in function 'func'
2023-04-25 21:45:06: ERROR[Main]: 	...inetest_test/bin/../builtin/profiler/instrumentation.lua:107: in function <...inetest_test/bin/../builtin/profiler/instrumentation.lua:100>
2023-04-25 21:45:06: ERROR[Main]: 	.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:432: in function <.../mt/5.6.1/Minetest_test/bin/../builtin/game/register.lua:418>

---

the following happens when clicking "read" with no message selected:

...t/bin/../worlds/basic_test/worldmods/mail/ui/message.lua:30: attempt to index local 'message' (a nil value)
stack traceback:
	...t/bin/../worlds/basic_test/worldmods/mail/ui/message.lua:30: in function 'show_message'
	...st/bin/../worlds/basic_test/worldmods/mail/ui/events.lua:169: in function 'func'
	/opt/minetest/bin/../builtin/profiler/instrumentation.lua:108: in function </opt/minetest/bin/../builtin/profiler/instrumentation.lua:101>
	/opt/minetest/bin/../builtin/game/register.lua:448: in function </opt/minetest/bin/../builtin/game/register.lua:434>

[S-S-X]

This doesn't seem good

mail/ui/message.lua

Line 99 in 47b18f2

local message = ""

Also seems this deserves to be linked to #70

[S-S-X]

I think root cause for crash is simply that both loops fail getting message:

mail/storage.lua

Lines 32 to 44 in 47b18f2

	function mail.get_message(playername, msg_id)
	local entry = mail.get_storage_entry(playername)
	for _, msg in ipairs(entry.inbox) do
	if msg.id == msg_id then
	return msg
	end
	end
	for _, msg in ipairs(entry.outbox) do
	if msg.id == msg_id then
	return msg
	end
	end
	end

Underlying issue, which seems to be ability to select messages that do not exist, stays even if formspec gets fixed so that normal players wont accidentally trigger these.

[Athozus]

@fluxionary what commit are you using ? The latest one or the 1.1.3 release ? I think @S-S-X is right so if you upgrade to last commit it should fix it. For my own I wasn't able to reproduce the crash.

[S-S-X]

I'm not sure what's there in different branches but what I've posted here were all like that in master branch atow.

[Athozus]

Yep, I'm talking about 47b18f2 in master.

[fluxionary]

@fluxionary what commit are you using ? The latest one or the 1.1.3 release ? I think @S-S-X is right so if you upgrade to last commit it should fix it. For my own I wasn't able to reproduce the crash.

running the lastest commit, i can't cause any of these.