Set is_ground_content in node definitions

[SwissalpS]

see pandorabox-io/pandorabox.io#836

some blocks like stainless steel are explicitly set to true, so I didn't touch them although I feel they should be set to false.

[BuckarooBanzay]

There's a luacheck error:

    technic/machines/LV/solar_panel.lua:52:2: value assigned to field is_ground_content is overwritten on line 61 before use

Also: you can ignore the other test-error(s) they should be fixed with #349

Correct me if i'm wrong but the is_ground_content flag is only relevant at mapgen and determines if the dungeon-gen replaces the nodes so this might be overkill for most artificially placed nodes and items (right?)

EDIT nevermind, didn't read up on pandorabox-io/pandorabox.io#836 but still: items should not have that flag IMO

[SwissalpS]

thanks for catching the solar panel error.

[OgelGames]

some blocks like stainless steel are explicitly set to true, so I didn't touch them although I feel they should be set to false.

Yeah, even if those blocks were to be placed by some kind of mapgen, they're not part of the ground.

but still: items should not have that flag IMO

The only change in items.lua is for technic:machine_casing, which is a node.

[SwissalpS]

That leaves marble and granite open for discussion. Also forcefields, which I consider not necessary.

[OgelGames]

Marble and granite are found in the ground, so they can be kept as-is. Forcefields are probably not necessary, but it also won't hurt anything to add that one little value :)

[SwissalpS]

OK, added removed forcefields from ground content

[BuckarooBanzay]

The only change in items.lua is for technic:machine_casing, which is a node.

my bad, i just read the diff-header which contained technic:carbon_cloth i should've read 2 lines more to get to the proper definition line :P