Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Dockerfile apt commands #6

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

wcedmisten
Copy link

Summary

  1. update and install commands should be on the same line, per official docs

Always combine RUN apt-get update with apt-get install in the same RUN statement.

  1. cleanup should be in the same layer as install to reduce docker layer size. See discussion here
  2. apt-get clean is redundant on images derived from Ubuntu base image. Same reference as 1)

Official Debian and Ubuntu images automatically run apt-get clean, so explicit invocation is not required.

@mtlynch
Copy link
Owner

mtlynch commented Dec 6, 2020

Thanks!

@mtlynch mtlynch merged commit a4442a1 into mtlynch:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants