A11y: Fix touch target size of some components

mtotschnig · Oct 20, 2024 · 29f5dd1 · 29f5dd1
1 parent 62b4bd5
commit 29f5dd1
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 12 deletions.
diff --git a/myExpenses/src/main/res/layout-v29/onboarding_theme_selection.xml b/myExpenses/src/main/res/layout-v29/onboarding_theme_selection.xml
@@ -3,8 +3,6 @@
 <Spinner xmlns:android="http://schemas.android.com/apk/res/android"
     android:id="@+id/themeSpinner"
     style="@style/OnboardingSpinner"
-    android:layout_width="match_parent"
-    android:layout_height="wrap_content"
     android:layout_gravity="center_vertical"
     android:entries="@array/pref_ui_theme_entries" />
 </merge>
diff --git a/myExpenses/src/main/res/layout/amount_edittext.xml b/myExpenses/src/main/res/layout/amount_edittext.xml
@@ -4,6 +4,7 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/AmountEditText"
     android:layout_width="0dp"
+    android:minHeight="@dimen/accessibility_clickable_minimum"
     android:layout_height="wrap_content"
     android:layout_gravity="center_vertical"
     android:layout_weight="1"

diff --git a/myExpenses/src/main/res/layout/color_input.xml b/myExpenses/src/main/res/layout/color_input.xml
@@ -4,15 +4,15 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/colorInput"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
+    android:layout_height="@dimen/accessibility_clickable_minimum"
     android:gravity="center_vertical"
     android:orientation="horizontal"
     tools:showIn="@layout/one_account">
 
     <androidx.appcompat.widget.AppCompatButton
         android:id="@+id/ColorIndicator"
         android:layout_width="0dp"
-        android:layout_height="40dp"
+        android:layout_height="match_parent"
         android:layout_gravity="center_vertical"
         android:layout_weight="1"
         android:contentDescription="@string/color_component_title"
@@ -22,7 +22,7 @@
         android:id="@+id/ColorEdit"
         style="?actionButtonStyle"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="match_parent"
         android:layout_gravity="center_vertical"
         android:contentDescription="@string/color_component_title"
         android:focusable="true"

diff --git a/myExpenses/src/main/res/layout/onboarding_wizzard_data.xml b/myExpenses/src/main/res/layout/onboarding_wizzard_data.xml
@@ -53,8 +53,6 @@
             <Spinner
                 android:id="@+id/Currency"
                 style="@style/OnboardingSpinner"
-                android:layout_width="match_parent"
-                android:layout_height="wrap_content"
                 android:layout_gravity="center_vertical" />
 
             <Button
@@ -96,8 +94,6 @@
                 <Spinner
                     android:id="@+id/AccountType"
                     style="@style/OnboardingSpinner"
-                    android:layout_width="match_parent"
-                    android:layout_height="wrap_content"
                     android:layout_gravity="center_vertical" />
 
                 <TextView

diff --git a/myExpenses/src/main/res/layout/one_expense.xml b/myExpenses/src/main/res/layout/one_expense.xml
@@ -380,15 +380,15 @@
                         <EditText
                             android:id="@+id/Comment"
                             android:layout_width="0dp"
-                            android:layout_height="wrap_content"
+                            android:layout_height="match_parent"
                             android:layout_gravity="center_vertical"
                             android:layout_weight="1"
                             android:inputType="textCapSentences|textMultiLine" />
 
                         <Spinner
                             android:id="@+id/Status"
                             android:layout_width="wrap_content"
-                            android:layout_height="wrap_content"
+                            android:layout_height="match_parent"
                             android:layout_gravity="center_vertical" />
 
                     </LinearLayout>

diff --git a/myExpenses/src/main/res/values/styles.xml b/myExpenses/src/main/res/values/styles.xml
@@ -43,13 +43,14 @@
     <style name="FormLabel">
         <item name="android:gravity">center_vertical</item>
         <item name="android:layout_gravity">center_vertical</item>
-        <item name="android:minHeight">50dp</item>
+        <item name="android:minHeight">@dimen/accessibility_clickable_minimum</item>
         <item name="android:layout_width">0dp</item>
         <item name="android:layout_weight">1</item>
         <item name="android:paddingEnd">12dp</item>
     </style>
 
     <style name="FormField">
+        <item name="android:minHeight">@dimen/accessibility_clickable_minimum</item>
         <item name="android:layout_width">0dp</item>
         <item name="android:layout_weight">@dimen/form_table_ratio</item>
         <item name="android:layout_gravity">center_vertical</item>
@@ -258,6 +259,8 @@
     </style>
 
     <style name="OnboardingSpinner">
+        <item name="android:layout_width">match_parent</item>
+        <item name="android:layout_height">@dimen/accessibility_clickable_minimum</item>
         <item name="android:layout_marginStart">-8dp</item>
     </style>