Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hotfix for broken occupancy bar. #167

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Add hotfix for broken occupancy bar. #167

wants to merge 1 commit into from

Conversation

tynsh
Copy link
Contributor

@tynsh tynsh commented Nov 16, 2022

No description provided.

@tynsh
Copy link
Contributor Author

tynsh commented Nov 16, 2022

I don't know why the test runner fails. Since this is a hotfix, maybe you can run the tests on your machine and force a merge. Maybe you'll need to remove the setting on the project settings page requiring all checks to succeed even for administrators.

christian-heusel
christian-heusel reviewed Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@christian-heusel christian-heusel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would propose a different fix 👍🏻 also we should add a test for this so it does not happen again 🤔
Let me know what you think, the only thing I would change is the default of occupancy level = 100% if there is no

muesli/web/templates/Fragments/HTML/tutorial_occupancy.pt Show resolved Hide resolved
muesli/web/templates/Fragments/HTML/tutorial_occupancy.pt Show resolved Hide resolved
@christian-heusel christian-heusel self-requested a review November 16, 2022 12:58
christian-heusel
christian-heusel approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@christian-heusel christian-heusel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misunderstood the changes at first, LGTM! 😊
Test is still needed tho!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-heusel christian-heusel christian-heusel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tynsh @christian-heusel