[ToggleButton][ToggleButtonGroup] Create ToggleButton and ToggleButtonGroup
#763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
new feature
Netlify deploy preview |
mj12albert
force-pushed
the
feat/toggle-button
branch
4 times, most recently
from
6c0fe92
to
6e04229
Compare
mj12albert
commented
Oct 29, 2024
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/toggle-button
branch
from
e07b2ef
to
f23c6df
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
feat/toggle-button
branch
5 times, most recently
from
9bcba83
to
3a74374
Compare
mj12albert
changed the title
ToggleButtonToggleButton and ToggleButtonGroup
mj12albert
force-pushed
the
feat/toggle-button
branch
2 times, most recently
from
7cc24fd
to
b06a97d
Compare
mj12albert
added
the
component: button group
mj12albert
force-pushed
the
feat/toggle-button
branch
10 times, most recently
from
bcdd1cc
to
7c449d8
Compare
github-actions
bot
removed
the
PR: out-of-date
|
@colmtuite just pinging you for a review 🙏 |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
feat/toggle-button
branch
from
26c97cd
to
54310b3
Compare
mj12albert
commented
Nov 27, 2024
Comment on lines
+108
to
+111
| if (textDirectionRef?.current == null) { | ||
| textDirectionRef.current = getTextDirection(element); | ||
| } | ||
| const isRtl = textDirectionRef.current === 'rtl'; |
There was a problem hiding this comment.
Caching this in a ref to mitigate against spamming the keys raised in #831 (comment)
mj12albert
force-pushed
the
feat/toggle-button
branch
from
54310b3
to
f4c3c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
Closes #31
Docs: