Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo for Utah-based deployment #7

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Update repo for Utah-based deployment #7

merged 6 commits into from
Oct 19, 2021

Conversation

JackWilb
Copy link
Member

@JackWilb JackWilb commented Oct 15, 2021

Updates all of the config to use the Utah infrastructure. I also took this time to add additional required variables, update the README, and migrate all of our DNS settings to route 53.

There are a couple of remaining items for me here, #5 and #6

@JackWilb
Copy link
Member Author

@AlmightyYakob when you give this a review, would you mind disconnecting the Kitware Terraform instance from running on PRs?

Copy link
Member

@jjnesbitt jjnesbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, one suggestion

name = "multinet.app"
type = "A"
ttl = "300"
records = ["75.2.60.5"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the netlify load balancer? It might be good to have a comment explaining this, otherwise it looks odd that all four of these routes go to the same IP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added your suggestion in 1287d4d

@JackWilb JackWilb merged commit 2d100df into main Oct 19, 2021
@JackWilb JackWilb deleted the utah-deploy branch October 19, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants