Ledger Address Table Pagination Feature #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroMargineanu
changed the title
arhtudormorar
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Added proper pagination to the Ledger provider address table, that allows navigating to custom pages of the table instead of the usual back and forth which was very slow. We've capped this to 500 pages allowing up to 5,000 addresses to be used. This can be easily modified.
Reproduce
Authenticate on any third party application leveraging on the package and try navigating between pages, it'll be very difficult since the only options are back and forth.
Additional Information
Feature doesn't exist on version
3.0.23ofsdk-dapp.This feature contains a slight breaking change because it now requires the
onGoToSpecificPageproperty callback to be sent to theAddressTablecomponent in order to handle navigation to pages other than the siblings.Contains breaking changes
Updated CHANGELOG
Testing