Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Table Pagination Count Support #1343

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Address Table Pagination Count Support #1343

merged 4 commits into from
Dec 9, 2024

Conversation

MiroMargineanu
Copy link
Contributor

@MiroMargineanu MiroMargineanu commented Dec 9, 2024 •
edited
Loading

Feature

Added support for the AddressTable and pagination component to support a count parameter in order to create a pagination with a fixed given amount of supported items and pages. Feature doesn't exist on version 3.1.1 of sdk-dapp.

Contains breaking changes

  • No
  • Yes

Updated CHANGELOG

  • No
  • Yes

Testing

  • User testing
  • Unit tests

@MiroMargineanu MiroMargineanu self-assigned this Dec 9, 2024
@MiroMargineanu MiroMargineanu added the enhancement New feature or request label Dec 9, 2024
@MiroMargineanu MiroMargineanu changed the title Add pagination count parameter. Address Table Pagination Count Support Dec 9, 2024
@MiroMargineanu MiroMargineanu merged commit 818caf9 into development Dec 9, 2024
1 check passed
@MiroMargineanu MiroMargineanu deleted the mm-add-pagination-items-count branch December 9, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radumojic radumojic radumojic approved these changes

Assignees

@MiroMargineanu MiroMargineanu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiroMargineanu @radumojic