Collision Object Callbacks #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove player_rumble_clips from collision_object by adding swept collision callback Collision object trigger passes in the collision object rather than the data pointer
mwpenny
requested changes
Oct 31, 2024
| if (object->body->flags & RigidBodyIsPlayer) { | ||
| playerHandleLandingRumble(-velocityDot); | ||
| } | ||
| if (object->sweptCollide) { |
There was a problem hiding this comment.
Minor: can you move this back into the if body? We should only get here if the objects are moving toward each other (i.e., not already handled/separated).
| @@ -141,10 +141,17 @@ void playerRender(void* data, struct DynamicRenderDataList* renderList, struct R | |||
| ); | |||
| } | |||
|
|
|||
| void playerHandleSweptCollision(struct CollisionObject* object, float velocityDot) { | |||
| // struct Player* player = object->data; | |||
There was a problem hiding this comment.
Nitpick: commented out code can be removed (looks like it's from before you updated the function signature).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove player_rumble_clips from collision_object by adding swept collision callback
Collision object trigger passes in the collision object rather than the data pointer