Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webrtc: Replace dsp and echoprobe by gst webrtcdsp and webrtcechoprobe #54

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

igsha
Copy link
Collaborator

@igsha igsha commented Apr 16, 2024

The standard webrtcdsp and webrtcechobprobe plugins has some andvantages compared to own VoiceProcessor and EchoProbe implementation:

  • wider capabilities (own implementation supports only rate=48000,channels=1,format=S16LE);
  • support noise supression;
  • no need to provide a reference to the echo probe element because it is used by name from a pipeline;
  • lower memory usage (perhaps there is memory leak in own implementation).

Totally remove own implementation.

Also add wasapi on windows.

@igsha igsha force-pushed the feat-webrtcdsp branch 7 times, most recently from 888bd76 to ed896a3 Compare April 17, 2024 11:59
@igsha igsha marked this pull request as ready for review April 17, 2024 12:14
.github/workflows/build.yml Outdated Show resolved Hide resolved
configure Outdated Show resolved Hide resolved
@mxlgv mxlgv requested review from kkonsw and vlomovtsev April 18, 2024 13:03
@mxlgv mxlgv merged commit 2eb0052 into mxlgv:master Apr 19, 2024
4 checks passed
@igsha igsha deleted the feat-webrtcdsp branch April 19, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants