OPENPGP PLUGIN: Show key as expired or revoked in account manager window #76
Conversation
|
@giantplaceholder do we need this change? |
Sure. And yes, strings' translation for Russian, English and German are must |
eerielili
force-pushed
the
openpgp-plugin-accountmanager-dontshowexpiredrevokedkeys
branch
from
890882c to
e149894
Compare
|
@giantplaceholder Thanks a lot for the review. I updated the translation template |
|
@eerielili please rebase CI for Windows has been fixed. |
eerielili
force-pushed
the
openpgp-plugin-accountmanager-dontshowexpiredrevokedkeys
branch
2 times, most recently
from
bcbc77f to
f26ccfd
Compare
|
@mxlgv done |
plugins/openpgp/po/ru.po
Outdated
| msgid "Encryption" | ||
| msgstr "Шифрование" | ||
|
|
||
| #~ msgid "No keys available. Generate one!" |
There was a problem hiding this comment.
Remove completely if the code is not used
plugins/openpgp/po/fr.po
Outdated
| msgid "Encryption" | ||
| msgstr "Chiffrement" | ||
|
|
||
| #~ msgid "No keys available. Generate one!" |
There was a problem hiding this comment.
Remove completely if the code is not used
plugins/openpgp/po/de.po
Outdated
|
|
||
| #: account_settings_entry.vala:95 | ||
| msgid "revoked!" | ||
| msgstr "" |
There was a problem hiding this comment.
Please add this translation:
"widerrufen!"
plugins/openpgp/po/de.po
Outdated
|
|
||
| #: account_settings_entry.vala:95 | ||
| msgid "expired!" | ||
| msgstr "" |
There was a problem hiding this comment.
Please add this translation:
"abgelaufen!"
plugins/openpgp/po/de.po
Outdated
| msgid "Encryption" | ||
| msgstr "Verschlüsselung" | ||
|
|
||
| #~ msgid "No keys available. Generate one!" |
There was a problem hiding this comment.
Remove completely if the code is not used
plugins/openpgp/po/de.po
Outdated
| #: account_settings_entry.vala:96 | ||
| #, c-format | ||
| msgid "Your key %s is %s" | ||
| msgstr "" |
There was a problem hiding this comment.
Please add this translation:
"Ihr Schlüssel %s ist %s"
f26ccfd to
1094f0e
Compare
|
Thanks. Wait a minute, I must pust a russian translation i deleted by mistake. Lines 33 to 37 in a8b2df7 |
eerielili
force-pushed
the
openpgp-plugin-accountmanager-dontshowexpiredrevokedkeys
branch
from
1094f0e to
a8b2df7
Compare
plugins/openpgp/po/ru.po
Outdated
|
|
||
| #: account_settings_entry.vala:95 | ||
| msgid "expired!" | ||
| msgstr "" |
plugins/openpgp/po/ru.po
Outdated
|
|
||
| #: account_settings_entry.vala:95 | ||
| msgid "revoked!" | ||
| msgstr "" |
plugins/openpgp/po/ru.po
Outdated
| #: account_settings_entry.vala:96 | ||
| #, c-format | ||
| msgid "Your key %s is %s" | ||
| msgstr "" |
eerielili
force-pushed
the
openpgp-plugin-accountmanager-dontshowexpiredrevokedkeys
branch
from
a8b2df7 to
22d5e58
Compare
- updated template translation file for the plugin.
- updated French translation for the plugin as well.
- Update German and Russian .po files skeletal as well.
eerielili
force-pushed
the
openpgp-plugin-accountmanager-dontshowexpiredrevokedkeys
branch
from
22d5e58 to
58f4f11
Compare
|
@eerielili Thank you for your contribution to the project. After the merger I will correct the translation. Don't worry about translation) |
| GPG.Key key_check = GPGHelper.get_public_key(account_key); | ||
| if(key_check.expired || key_check.revoked) { | ||
| string status_str = key_check.expired ? _("expired!") : _("revoked!"); | ||
| label.set_markup(build_markup_string(_("Attention required!"), _("Your key <span color='red'><b>"+ key_check.fpr +"</b></span> is " + status_str))); |
There was a problem hiding this comment.
I'll use the _("stuff is %s").printf( thestuffs_var ) here to ease adding to the .pot, will force push change a little change in my branch in a few minutes.
plugins/openpgp/po/ru.po
Outdated
|
|
||
| #: account_settings_entry.vala:95 | ||
| msgid "expired!" | ||
| msgstr "" |
There was a problem hiding this comment.
@mxlgv oh right, I didn't see the parent comment until now, sorry! will update very shortly.
By the way, what do you think will fit well for "Attention required" in Russian?
thanks you very much for your patience
A small update concerning the openpgp plugin: with this, the key can be shown either as expired or revoked in the account manager windows concerning an account.
