Configure how often upload progress event emitted, as well as UI revamp

[joelwass]

The justification for the UI revamp is as follows:

• Quite frankly I feel like only the transfers that occur in the current session use of the application should be logged - and not the complete history of the transferUtility.
• I also logged in a more modular fashion so that users can look back on the progress, states, and file directories even after the upload/download succeeded or failed. Previously, once the upload failed or succeeded, the UI made it impossible to see the log of what occurred in the process, for example an error.
• I additionally increased error logging visibility and the logging of both the s3 path of where the upload goes as well as the local file path of where a download goes.

[joelwass]

ah hold up on this, only implemented in Android, will implement in iOS

[jhen0409]

Thanks! I'll take time to review it. 😄

[jhen0409]

Just sendEvent("State_Changed", result)? There are different?

Also, I prefer to use @_RNS3_ as a event name prefix, we must ensure it don't conflict with other libraries.

[jhen0409]

Currently we handle @_RNS3_Events and save progress to AsyncStorage, then call subscribers, let iOS version work well like Android version (because they are different 😂), it looks your PR will break this behavior.

I think we should keep the old way and split event into@_RNS3_STATE_CHANGED, @_RNS3_PROGESS_CHANGED, @_RNS3_ERROR. @joelwass, what do you think?

[joelwass]

I think that's a great idea

On Jul 27, 2016, at 11:49 PM, Jhen-Jie Hong [email protected] wrote:

Currently we handle @_RNS3_Events and save progress to AsyncStorage, then call subscribers, let iOS version work well like Android version (because they are different 😂), it looks your PR will break this behavior.

I think we should keep the old way and split event into@_RNS3_STATE_CHANGED, @_RNS3_PROGESS_CHANGED, @_RNS3_ERROR. @joelwass, what do you think?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[joelwass]

Any update on this?