fix state in user list

mycloudnexus · Dec 2, 2024 · 075e4f5 · 075e4f5
1 parent 69996a5
commit 075e4f5
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 2 deletions.
diff --git a/...a-sdk-auth/src/main/java/com/consoleconnect/kraken/operator/auth/repo/UserRepository.java b/...a-sdk-auth/src/main/java/com/consoleconnect/kraken/operator/auth/repo/UserRepository.java
@@ -1,6 +1,7 @@
 package com.consoleconnect.kraken.operator.auth.repo;
 
 import com.consoleconnect.kraken.operator.auth.entity.UserEntity;
+import com.consoleconnect.kraken.operator.auth.enums.UserStateEnum;
 import java.util.List;
 import java.util.Optional;
 import java.util.UUID;
@@ -24,5 +25,5 @@ public interface UserRepository
               + "  and  ((:role) is null or  e.role = :role)")
   @Transactional(readOnly = true)
   Page<UserEntity> search(
-      String q, Pageable pageable, List<String> filterRoles, String state, String role);
+      String q, Pageable pageable, List<String> filterRoles, UserStateEnum state, String role);
 }
diff --git a/...a-sdk-auth/src/main/java/com/consoleconnect/kraken/operator/auth/service/UserService.java b/...a-sdk-auth/src/main/java/com/consoleconnect/kraken/operator/auth/service/UserService.java
@@ -19,6 +19,7 @@
 import java.util.*;
 import lombok.AllArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
+import org.apache.commons.lang3.StringUtils;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.PageRequest;
@@ -134,12 +135,14 @@ public User create(CreateUserRequest request, String createdBy) {
   public Paging<User> search(
       String q, PageRequest pageRequest, boolean filterInternalUser, String state, String role) {
     log.info("Searching users, q:{}, pageRequest:{}", q, pageRequest);
+    UserStateEnum userStateEnum =
+        (StringUtils.isBlank(state) ? null : UserStateEnum.valueOf(state));
     Page<UserEntity> userEntityPage =
         userRepository.search(
             q,
             pageRequest,
             filterInternalUser ? List.of(UserRoleEnum.INTERNAL_USER.name()) : null,
-            state,
+            userStateEnum,
             role);
     log.info("Users found:{}", userEntityPage.getTotalElements());
     return PagingHelper.toPaging(userEntityPage, UserMapper.INSTANCE::toUser);

diff --git a/.../test/java/com/consoleconnect/kraken/operator/auth/controller/UserMgmtControllerTest.java b/.../test/java/com/consoleconnect/kraken/operator/auth/controller/UserMgmtControllerTest.java
@@ -22,6 +22,7 @@
 import com.fasterxml.jackson.core.type.TypeReference;
 import java.util.*;
 import java.util.function.Consumer;
+import lombok.extern.slf4j.Slf4j;
 import org.junit.jupiter.api.*;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.mock.mockito.SpyBean;
@@ -31,6 +32,7 @@
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.web.reactive.server.WebTestClient;
 
+@Slf4j
 @ActiveProfiles("test-login-enabled")
 @MockIntegrationTest
 @ContextConfiguration(classes = {TestApplication.class})
@@ -429,6 +431,25 @@ void givenUserCreated_whenSearch_thenReturnOk() {
           assertThat(bodyStr, hasJsonPath("$.data.data", hasSize(greaterThanOrEqualTo(1))));
           assertThat(bodyStr, hasJsonPath("$.data.data[0].email", equalTo("[email protected]")));
         });
+
+    // search by role and state
+    testClientHelper.requestAndVerify(
+        HttpMethod.GET,
+        (uriBuilder ->
+            uriBuilder
+                .path("/users")
+                .queryParam("role", "USER")
+                .queryParam("state", "ENABLED")
+                .build()),
+        headers,
+        null,
+        HttpStatus.OK.value(),
+        bodyStr -> {
+          log.info("bodyStr:{}", bodyStr);
+          Assertions.assertNotNull(bodyStr);
+          assertThat(bodyStr, hasJsonPath("$.data.data", notNullValue()));
+          assertThat(bodyStr, hasJsonPath("$.data.data", hasSize(greaterThanOrEqualTo(3))));
+        });
   }
 
   @Test