Skip to content

Commit

Permalink
fix(sdk): add more state check for completionDate (#226)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhiyaoPCCW authored Nov 22, 2024
1 parent e160ea9 commit 0a93a9f
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ spec:
source: ""
sourceLocation: "BODY"
target: "@{{completionDate}}"
checkPath: "$[?(@.state == 'completed')]"
checkPath: "$[?(@.state == 'completed'||@.state == 'failed'||@.state == 'partial'||@.state == 'rejected'||@.state == 'cancelled')]"
deletePath: "$.completionDate"
targetLocation: "BODY"
requiredMapping: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ spec:
sourceLocation: "BODY"
target: "@{{completionDate}}"
targetLocation: "BODY"
checkPath: "$[?(@.state == 'completed')]"
checkPath: "$[?(@.state == 'completed'||@.state == 'failed'||@.state == 'partial'||@.state == 'rejected'||@.state == 'cancelled')]"
deletePath: "$.completionDate"
requiredMapping: false
- name: mapper.order.eline.read.instanceId
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ spec:
source: ""
sourceLocation: "BODY"
target: "@{{completionDate}}"
checkPath: "$[?(@.state == 'completed')]"
checkPath: "$[?(@.state == 'completed'||@.state == 'failed'||@.state == 'partial'||@.state == 'rejected'||@.state == 'cancelled')]"
deletePath: "$.completionDate"
targetLocation: "BODY"
requiredMapping: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ spec:
source: ""
sourceLocation: "BODY"
target: "@{{completionDate}}"
checkPath: "$[?(@.state == 'completed')]"
checkPath: "$[?(@.state == 'completed'||@.state == 'failed'||@.state == 'partial'||@.state == 'rejected'||@.state == 'cancelled')]"
deletePath: "$.completionDate"
targetLocation: "BODY"
requiredMapping: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ spec:
- classpath:/mef-sonata/mapping-matrix/mapping.matrix.inventory.eline.read.yaml
- classpath:/mef-sonata/mapping-matrix/mapping.matrix.inventory.uni.list.yaml
- classpath:/mef-sonata/mapping-matrix/mapping.matrix.inventory.eline.list.yaml
- classpath:/mef-sonata/template-upgrade/release.1.5.22.yaml
- classpath:/mef-sonata/template-upgrade/release.1.5.23.yaml


templateUpgradePaths:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
kind: kraken.product.template-upgrade
apiVersion: v1
metadata:
key: kraken.product.template-upgrade.1.5.23
name: V1.5.23
labels:
productSpec: grace
productVersion: V1.5.23
publishDate: 2024-11-22
description: |
Remove completionDate when state != completed.
version: 2

0 comments on commit 0a93a9f

Please sign in to comment.