fix(sdk): added price negative checking for quote (#211)

mycloudnexus · Nov 20, 2024 · d31eec6 · d31eec6
1 parent 65c01ea
commit d31eec6
Show file tree

Hide file tree

Showing 9 changed files with 24 additions and 25 deletions.
diff --git a/kraken-app/kraken-app-hub/src/test/resources/expected/expected-9-quote.uni.add.sync.json b/kraken-app/kraken-app-hub/src/test/resources/expected/expected-9-quote.uni.add.sync.json
@@ -8,7 +8,7 @@
       "product": "${mefRequestBody.quoteItem[0].product}",
       "action": "add",
       "id": "${mefRequestBody.quoteItem[0].id}",
-      "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value==''?'unableToProvide':'approved.orderable'))",
+      "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value=='')or(T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value)<0)?'unableToProvide':'approved.orderable'))",
       "quoteItemTerm": "${T(java.util.Arrays).asList(mefRequestBody.quoteItem[0].requestedQuoteItemTerm)}",
       "quoteItemPrice": [
         {
@@ -37,5 +37,5 @@
   "instantSyncQuote": "${mefRequestBody[instantSyncQuote]?:''}",
   "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}",
   "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}",
-  "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value==''?'unableToProvide':'approved.orderable'))"
+  "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value=='')or(T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value)<0)?'unableToProvide':'approved.orderable'))"
 }
diff --git a/...p/kraken-app-hub/src/test/resources/mock/api-targets/api-target.quote.eline.add.sync.yaml b/...p/kraken-app-hub/src/test/resources/mock/api-targets/api-target.quote.eline.add.sync.yaml
@@ -31,7 +31,7 @@ spec:
              "product": "${mefRequestBody.quoteItem[0].product}",
              "action": "add",
              "id": "${mefRequestBody.quoteItem[0].id}",
-             "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))",
+             "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))",
              "quoteItemTerm": "${T(java.util.Arrays).asList(mefRequestBody.quoteItem[0].requestedQuoteItemTerm)}",
              "quoteItemPrice": [{
                "unitOfMeasure":"",
@@ -57,5 +57,5 @@ spec:
           "instantSyncQuote":"${mefRequestBody[instantSyncQuote]?:''}",
           "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}",
           "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}",
-          "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))"
+          "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))"
         }
diff --git a/...app/kraken-app-hub/src/test/resources/mock/api-targets/api-target.quote.uni.add.sync.yaml b/...app/kraken-app-hub/src/test/resources/mock/api-targets/api-target.quote.uni.add.sync.yaml
@@ -33,7 +33,7 @@ spec:
               "product": "${mefRequestBody.quoteItem[0].product}",
               "action": "add",
               "id": "${mefRequestBody.quoteItem[0].id}",
-              "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))",
+              "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))",
               "quoteItemTerm": "${T(java.util.Arrays).asList(mefRequestBody.quoteItem[0].requestedQuoteItemTerm)}",
               "quoteItemPrice": [{
                 "unitOfMeasure":"",
@@ -60,5 +60,5 @@ spec:
           "instantSyncQuote":"${mefRequestBody[instantSyncQuote]?:''}",
           "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}",
           "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}",
-          "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))"
+          "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))"
         }
diff --git a/...va-sdk-mef/src/main/resources/mef-sonata/api-targets/api-target.quote.eline.add.sync.yaml b/...va-sdk-mef/src/main/resources/mef-sonata/api-targets/api-target.quote.eline.add.sync.yaml
@@ -31,7 +31,7 @@ spec:
              "product": "${mefRequestBody.quoteItem[0].product}",
              "action": "add",
              "id": "${mefRequestBody.quoteItem[0].id}",
-             "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))",
+             "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))",
              "quoteItemTerm": "${T(java.util.Arrays).asList(mefRequestBody.quoteItem[0].requestedQuoteItemTerm)}",
              "quoteItemPrice": [{
                "unitOfMeasure":"",
@@ -57,5 +57,5 @@ spec:
           "instantSyncQuote":"${mefRequestBody[instantSyncQuote]?:''}",
           "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}",
           "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}",
-          "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))"
+          "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))"
         }
diff --git a/...java-sdk-mef/src/main/resources/mef-sonata/api-targets/api-target.quote.uni.add.sync.yaml b/...java-sdk-mef/src/main/resources/mef-sonata/api-targets/api-target.quote.uni.add.sync.yaml
@@ -33,7 +33,7 @@ spec:
               "product": "${mefRequestBody.quoteItem[0].product}",
               "action": "add",
               "id": "${mefRequestBody.quoteItem[0].id}",
-              "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))",
+              "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))",
               "quoteItemTerm": "${T(java.util.Arrays).asList(mefRequestBody.quoteItem[0].requestedQuoteItemTerm)}",
               "quoteItemPrice": [{
                 "unitOfMeasure":"",
@@ -60,5 +60,5 @@ spec:
           "instantSyncQuote":"${mefRequestBody[instantSyncQuote]?:''}",
           "requestedQuoteCompletionDate": "${mefRequestBody[requestedQuoteCompletionDate]?:''}",
           "quoteLevel": "${mefRequestBody.buyerRequestedQuoteLevel}",
-          "state": "((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '' ? 'unableToProvide': 'approved.orderable'))"
+          "state": "(((mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value == '') or (T(java.lang.Double).parseDouble(mefResponseBody.quoteItem[0].quoteItemPrice[0].price.dutyFreeAmount.value) < 0)? 'unableToProvide': 'approved.orderable'))"
         }
diff --git a/kraken-java-sdk/kraken-java-sdk-mef/src/main/resources/mef-sonata/product.yaml b/kraken-java-sdk/kraken-java-sdk-mef/src/main/resources/mef-sonata/product.yaml
@@ -98,7 +98,7 @@ spec:
     - classpath:/mef-sonata/mapping-matrix/mapping.matrix.inventory.eline.read.yaml
     - classpath:/mef-sonata/mapping-matrix/mapping.matrix.inventory.uni.list.yaml
     - classpath:/mef-sonata/mapping-matrix/mapping.matrix.inventory.eline.list.yaml
-    - classpath:/mef-sonata/template-upgrade/release.1.5.16.yaml
+    - classpath:/mef-sonata/template-upgrade/release.1.5.17.yaml
 
 
   templateUpgradePaths:

diff --git a/...dk/kraken-java-sdk-mef/src/main/resources/mef-sonata/template-upgrade/release.1.5.16.yaml b/...dk/kraken-java-sdk-mef/src/main/resources/mef-sonata/template-upgrade/release.1.5.16.yaml
diff --git a/...dk/kraken-java-sdk-mef/src/main/resources/mef-sonata/template-upgrade/release.1.5.17.yaml b/...dk/kraken-java-sdk-mef/src/main/resources/mef-sonata/template-upgrade/release.1.5.17.yaml
@@ -0,0 +1,13 @@
+---
+kind: kraken.product.template-upgrade
+apiVersion: v1
+metadata:
+  key: kraken.product.template-upgrade.1.5.17
+  name: V1.5.17
+  labels:
+    productSpec: grace
+    productVersion: V1.5.17
+    publishDate: 2024-11-20
+  description: |
+    Added negative validation for price value in quote list
+  version: 2
diff --git a/kraken-java-sdk/pom.xml b/kraken-java-sdk/pom.xml
@@ -6,7 +6,6 @@
     <artifactId>kraken-java-sdk</artifactId>
     <name>kraken-java-sdk</name>
     <version>1.0.0-rc.0</version>
-
     <packaging>pom</packaging>
     <parent>
         <groupId>com.consoleconnect.kraken</groupId>