Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix the test failed in ProductDeploymentController #5

Closed
DaveXiong opened this issue Oct 14, 2024 · 0 comments · Fixed by #7
Closed

[BUG] Fix the test failed in ProductDeploymentController #5

DaveXiong opened this issue Oct 14, 2024 · 0 comments · Fixed by #7
Assignees
@DaveXiong
Labels
bug Something isn't working

Comments

@DaveXiong
Copy link
Contributor

DaveXiong commented Oct 14, 2024 •
edited
Loading

Describe the bug

In the PR #2, there is a test case failed:

Error:    ProductDeploymentControllerTest.givenValidStageDeployment_whenDeployToProduction_thenOK:481-
>lambda$givenValidStageDeployment_whenDeployToProduction_thenOK$50:492 expected: <2> but was: <3>

Details can be found in https://github.com/mycloudnexus/kraken/actions/runs/11336434050/job/31526344905?pr=2
@DaveXiong DaveXiong added the bug Something isn't working label Oct 14, 2024
This was referenced Oct 14, 2024
Merged
Merged
@DaveXiong DaveXiong self-assigned this Oct 15, 2024
@DaveXiong DaveXiong linked a pull request Oct 15, 2024 that will close this issue
fix(sdk): fix the wrong test case assertion #7
Merged
7 tasks
KsiBart pushed a commit that referenced this issue Oct 29, 2024
@jmoeser
Test release pipeline (#5)
642dc23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaveXiong DaveXiong

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sdk): fix the wrong test case assertion mycloudnexus/kraken
1 participant
@DaveXiong