Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): fix the wrong test case assertion #7

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

DaveXiong
Copy link
Contributor

@DaveXiong DaveXiong commented Oct 15, 2024

Description

Everything is good when running https://github.com/mycloudnexus/kraken/blob/main/kraken-java-sdk/kraken-java-sdk-controller/src/test/java/com/consoleconnect/kraken/operator/controller/v2/ProductDeploymentControllerTest.java

But there are some test cases failed when running test on the full project.
The issue should be caused by multiple test cases may generate the same cases, which cause the assertion not correct.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@DaveXiong DaveXiong linked an issue Oct 15, 2024 that may be closed by this pull request
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

@DaveXiong DaveXiong merged commit 0e246d6 into main Oct 15, 2024
4 checks passed
@DaveXiong DaveXiong deleted the dxiong/fix/unit-test-product-deployment branch October 15, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fix the test failed in ProductDeploymentController
1 participant