Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): fix issue with api path display #185

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

james-tran-3005
Copy link
Contributor

@james-tran-3005 james-tran-3005 commented Nov 18, 2024

Description

  • Make all api path display left truncated when there is no space to accommodate the full path. Hover on truncated path will show a tooltip with full path displayed
  • Fix seller api description default shows 'description' despite of holding no value
  • Fix api spec table method overlaps with api path

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@james-tran-3005 james-tran-3005 requested a review from a team as a code owner November 18, 2024 10:04
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@james-tran-3005 james-tran-3005 force-pushed the fix/common_api_path_display branch from a0ffd7d to 706dd68 Compare November 19, 2024 02:50
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

KsiBart
KsiBart previously approved these changes Nov 19, 2024
@james-tran-3005 james-tran-3005 force-pushed the fix/common_api_path_display branch from 6d9c612 to fe5711f Compare November 20, 2024 01:02
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

"envId": "7da9098b-107f-402c-9d6d-20b1be96b99a",
"envName": "production",
"createAt": "2024-11-18T10:06:14.412978Z",
"createBy": "24044233-3683-425e-9cbe-62e643f081d8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the testing data, do not expose personal name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied api response and forgot to change it. Won't producing same issue again.

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

Copy link

Copy link
Contributor

@zhiyaoPCCW zhiyaoPCCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiyaoPCCW zhiyaoPCCW merged commit 6266740 into v1 Nov 20, 2024
6 checks passed
@zhiyaoPCCW zhiyaoPCCW deleted the fix/common_api_path_display branch November 20, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants