Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): remove status condition #190

Merged

Conversation

kuangxiang20240501
Copy link
Contributor

@kuangxiang20240501 kuangxiang20240501 commented Nov 19, 2024

Description

Related Issue

#186

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@kuangxiang20240501 kuangxiang20240501 requested a review from a team as a code owner November 19, 2024 01:49
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

Copy link

Copy link
Contributor

@xuelianhan007 xuelianhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

Copy link
Contributor

@zhiyaoPCCW zhiyaoPCCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuangxiang20240501 kuangxiang20240501 merged commit 0d90a09 into v1 Nov 19, 2024
6 checks passed
@kuangxiang20240501 kuangxiang20240501 deleted the zywang/fix/synchronize-buyer-without-status-0947 branch November 19, 2024 02:00
james-tran-3005 pushed a commit that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants