Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(misc): bump kraken-app-portal version #20

Merged
merged 3 commits into from
Oct 30, 2024
Merged

build(misc): bump kraken-app-portal version #20

merged 3 commits into from
Oct 30, 2024

Conversation

KsiBart
Copy link
Contributor

@KsiBart KsiBart commented Oct 29, 2024 •
edited
Loading

Description

Upgrade versions from downstream v0.188.0 to v0.230.0.

  1. Feature Update: Separated location and property name fields on Mapping page; users can now update property location details.
  2. Admin Functionality: Enabled deletion of unused seller API servers for streamlined management.
  3. Buyer Management: Added functionality to deactivate active buyers, rotated buyer tokens for security, and improved buyer management UI.
  4. Mapping Template: Released the initial version of the upgraded mapping template.
  5. UI Enhancements: Addressed responsive design issues for better user experience across devices.

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

Add features and fix bugs

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

DaveXiong
DaveXiong reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@DaveXiong DaveXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments added

kraken-app/kraken-app-portal/LICENSE Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LICENSE file can be deleted , there is a LICENSE file in the base of this github repo

kraken-app/kraken-app-portal/NOTICE Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same to LICENSE, can be deleted

kraken-app/kraken-app-portal/package.json Outdated
@@ -1,30 +1,38 @@
{
"name": "kraken-app-portal",
"name": "kraken-portal",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's possible to keep the name kraken-app-portal

kraken-app/kraken-app-portal/sonar-project.properties Outdated
@@ -0,0 +1,5 @@
sonar.projectKey=Console-Core_kraken-portal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove sonar-*.properties pls, we will config sonar later.

@DaveXiong
Copy link
Contributor

@KsiBart Can you help to add description on hightlight the features will be supported in the PR?

@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

DaveXiong
DaveXiong approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@DaveXiong DaveXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveXiong DaveXiong merged commit 2e8428f into main Oct 30, 2024
5 checks passed
@DaveXiong DaveXiong deleted the update-v0.230.0 branch October 30, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveXiong DaveXiong DaveXiong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KsiBart @DaveXiong