Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(portal): fix deployment history/api mappings table is not full height #240

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix(portal): fix deployment history/api mappings table is not full height #240

merged 2 commits into from
Nov 28, 2024

Conversation

james-tran-3005
Copy link
Contributor

Description

fix deployment history/api mappings table is not full height

Related Issue

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@james-tran-3005 james-tran-3005 requested a review from a team as a code owner November 27, 2024 07:32
@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@james-tran-3005 james-tran-3005 force-pushed the fix_deployment_table_height branch from f43c23a to cc7e022 Compare November 27, 2024 07:44
@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@james-tran-3005 james-tran-3005 force-pushed the fix_deployment_table_height branch from cc7e022 to c472db7 Compare November 27, 2024 07:56
@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@james-tran-3005 james-tran-3005 force-pushed the fix_deployment_table_height branch from c472db7 to e7afbb5 Compare November 27, 2024 08:05
@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

zhiyaoPCCW
zhiyaoPCCW approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@zhiyaoPCCW zhiyaoPCCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'kraken_nodejs'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'kraken_java'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@james-tran-3005 james-tran-3005 merged commit 81cee3f into main Nov 28, 2024
6 checks passed
@james-tran-3005 james-tran-3005 deleted the fix_deployment_table_height branch November 28, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiyaoPCCW zhiyaoPCCW zhiyaoPCCW approved these changes

@miyaflowercat miyaflowercat miyaflowercat approved these changes

@KsiBart KsiBart KsiBart approved these changes

Assignees
No one assigned
Labels
1.1.0-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@james-tran-3005 @KsiBart @miyaflowercat @zhiyaoPCCW @kuangxiang20240501