Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal): push activity log UI issues #285

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

KsiBart
Copy link
Contributor

@KsiBart KsiBart commented Dec 9, 2024

Description

Fixes:

  1. Future time range should not be selected in date picker
  2. After user selected date range and environment, label "Number of activity logs filtered" is missing
  3. When log is filtered as 0. "OK" button should be disabled

Related Issue

#277

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

392673242-a19b0622-2731-483a-88dc-c9b138d260fb

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@KsiBart KsiBart requested a review from a team as a code owner December 9, 2024 08:08
@KsiBart KsiBart linked an issue Dec 9, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@KsiBart KsiBart changed the title fix(portal): Push activity log UI issues fix(portal): push activity log UI issues Dec 9, 2024
Copy link
Contributor

@james-tran-3005 james-tran-3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

sonarqubecloud bot commented Dec 9, 2024

Copy link

sonarqubecloud bot commented Dec 9, 2024

@KsiBart KsiBart merged commit 13c256f into main Dec 9, 2024
7 checks passed
@KsiBart KsiBart deleted the 277-bug-push-activity-log-ui-issues branch December 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Push activity log UI issues
3 participants