Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): kraken-250 - add SchedLock support for app-agent schedulers (multiple instances) #292

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

jaroslawmalekcodete
Copy link
Contributor

Description

Add SchedLock support https://github.com/lukas-krecan/ShedLock for app-agent schedulers

Related Issue

#250

Motivation and Context

How This Has Been Tested

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@jaroslawmalekcodete jaroslawmalekcodete requested a review from a team as a code owner December 12, 2024 14:31
Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
nanoid 3.3.7 Low 3.3.8 GHSA-mwcw-c2x4-8c55
nanoid 5.0.7 Low 5.0.9 GHSA-mwcw-c2x4-8c55

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
nanoid 3.3.7 Medium 3.3.8 GHSA-mwcw-c2x4-8c55
nanoid 5.0.7 Medium 5.0.9 GHSA-mwcw-c2x4-8c55

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
nanoid 3.3.7 Medium 3.3.8 GHSA-mwcw-c2x4-8c55

Copy link
Contributor

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID
nanoid 3.3.7 Medium 3.3.8 GHSA-mwcw-c2x4-8c55

Copy link

Copy link

Copy link
Contributor

@zhiyaoPCCW zhiyaoPCCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kuangxiang20240501 kuangxiang20240501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuangxiang20240501 kuangxiang20240501 merged commit ac907b1 into main Dec 23, 2024
7 checks passed
@kuangxiang20240501 kuangxiang20240501 deleted the jarek/kraken-250_shed_lock branch December 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants