Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): added support of buyer tokens with different environments #58

Merged
merged 20 commits into from
Nov 7, 2024

Conversation

xuelianhan007
Copy link
Contributor

@xuelianhan007 xuelianhan007 commented Nov 1, 2024

Description

Added support of buyer tokens with environment signature so that the buyer tokens will be separated by different environments.
The configurations alteration pull request is as following:
https://github.com/mycloudnexus/kraken-deployment-config/pull/31

Related Issue

#35

Motivation and Context

How This Has Been Tested

These patch has been verified with integration test in localhost.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)
  • CI/CD or documentation update (changes to CI/CD pipeline or documentation)

Checklist

  • I ensured that the documentation is up to date
  • I explained why this PR updates in detail with reasoning why it's required
  • I would like a code coverage CI quality gate exception and have explained why

@xuelianhan007 xuelianhan007 requested a review from a team as a code owner November 1, 2024 08:56
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 1, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@@ -18,7 +18,7 @@ spec:
- classpath:/mef-sonata/api-specs/api-spec.quote.yaml
- classpath:/mef-sonata/api-specs/api-spec.product.offering.yaml
- classpath:/mef-sonata/api-targets/api-target.order.uni.add.yaml
- classpath:/mef-sonata/api-targets/api-target.order.eline.add.yam
- classpath:/mef-sonata/api-targets/api-target.order.eline.add.yaml
- classpath:/mef-sonata/api-targets/api-target.order.uni.add.yaml
- classpath:/mef-sonata/api-targets/api-target.order.eline.add.yaml
Copy link
Contributor

@kuangxiang20240501 kuangxiang20240501 Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classpath:/mef-sonata/api-targets/api-target.order.eline.add.yaml duplicate content in lines(21,23), can u delete one of them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The duplicated lines have been deleted.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

@kuangxiang20240501 kuangxiang20240501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

@zhiyaoPCCW zhiyaoPCCW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @DaveXiong please help to review it.

@zhiyaoPCCW zhiyaoPCCW requested a review from DaveXiong November 5, 2024 03:03
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link

sonarqubecloud bot commented Nov 7, 2024

Copy link
Contributor

@DaveXiong DaveXiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuelianhan007 xuelianhan007 merged commit 29d49d0 into main Nov 7, 2024
6 checks passed
@xuelianhan007 xuelianhan007 deleted the fix/fix-buyer-token-without-env branch November 7, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants