-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): added company id and name in activity log list #65
Conversation
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
public interface BuyerCreator { | ||
String PRODUCT_ID = "product.mef.sonata.api"; | ||
String BUYER_BASE_URL = String.format("/products/%s/buyers", PRODUCT_ID); | ||
String BUYER_ID = "consolecore-poping-company"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace the name with a mock one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The test data has been renamed.
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
…d-company-in-activity-log
Library Vulnerability scan resultsThe following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies). Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.
|
Quality Gate passed for 'kraken_nodejs'Issues Measures |
Quality Gate passed for 'kraken_java'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added support of showing company id and name in activity log list.
Related Issue
#33
Motivation and Context
How This Has Been Tested
Integration test and verified in internal development environment.
Screenshots (if appropriate)
Types of changes
Checklist