Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(misc): customise sonar.cloud via github vars #69

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Conversation

DaveXiong
Copy link
Contributor

@DaveXiong DaveXiong commented Nov 5, 2024

Description

  1. replace mvn with mvnw
  2. support customise sonar.cloud via the following github variables
  • SONAR_ORGANIZATION
  • SONAR_JAVA_PROJECT_KEY
  • SONAR_NODEJS_PROJECT_KEY
    And I already added the above three variables into this repo

@DaveXiong DaveXiong requested a review from a team as a code owner November 5, 2024 06:53
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@DaveXiong DaveXiong marked this pull request as draft November 6, 2024 01:10
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@DaveXiong DaveXiong changed the title build(misc): replace mvn with mvnw in ci.yaml build(misc): customise sonar.cloud via github vars Nov 6, 2024
@DaveXiong DaveXiong closed this Nov 6, 2024
@DaveXiong DaveXiong reopened this Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

@DaveXiong DaveXiong closed this Nov 6, 2024
@DaveXiong DaveXiong reopened this Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Library Vulnerability scan results

The following vulnerabilities have been found in libraries included in the repository (some might be dependencies of dependencies).

Critical 🔴 and High 🟡 severity vulnerabilities must be fixed before the PR can be merged, even if they are dependencies of dependencies.

Library Vulnerable version Severity Fix version Vulnerability ID

Copy link

sonarqubecloud bot commented Nov 6, 2024

Copy link

sonarqubecloud bot commented Nov 6, 2024

@DaveXiong DaveXiong marked this pull request as ready for review November 6, 2024 04:55
@DaveXiong
Copy link
Contributor Author

@jmoeser this patch is ready for review.

@DaveXiong DaveXiong merged commit 3f8a633 into main Nov 6, 2024
10 of 14 checks passed
@DaveXiong DaveXiong deleted the github/ci branch November 6, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants