Exploit Vulnerability as an action #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pf2e system has an issue where you can't have a target for a check unless that check is against a *named* DC on the target. A DC specified numerically doesn't work. EV uses the standard level based DC for the target, which doesn't exist as a named DC, so this is a problem. It is possible to create a new named DC using the SpecialStatistic RE, and that's what these effects do. An EphemeralEffect RE on the roller can be used to give these effects to the target of the EV check for the roll. The new statistic is named DC and targetting the check works. There are two, one for the proficiency without level variant and one for normal rules. The system doesn't automatically subtract actor level from SpecialStatistic proficiency bonuses when PwoL is used.
This adds a synthetic rule during the derived data wrapper to give an EphemeralEffect RE to thaum actors (with the EV feature). The EE will give targets of EV a new DC to roll against for the EV check. It would make sense to put this RE on the EV class feature, but that's a system item and auto-modifiying those has issues. Also, by doing it in code, it can choose the normal of PwoL variant of the DC to apply. It wouldn't work to put it on (each) implement, as the module doesn't enforce holding an implement to use EV.
This reuses the SingleCheckAction class from the system for the mechanics of the roll. More of the system automation works this way. The only thing it needs to do is setup the Diverse Lore DC text in the roll note. Maybe it's possible to get the system to inject that too?
xyzzy42
force-pushed
the
ev-as-action
branch
from
1205133 to
a296452
Compare
|
In 6.8.1, this isn't evaluating the roll vs the DC, and the degree of success is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to get the EV roll to follow all the system automation stuff, by using the
SingleCheckActionclass from the system used by a bunch of other actions.Everything appears to work. The trick is to use an EphemeralEffect to the give the target of the EV check an effect that uses a SpecialStatistic to give the target an EV DC to roll against.
There is one issue, the action code doesn't know how to make a translated check-DC label for lore skills. There's already a " Check" translation format it could use, but the bit of code doing the flavor text doesn't do that. I've got a PR for the system that fixes this, foundryvtt/pf2e#17223