Fix complex exceptions for Breached Defenses such as Magical Silver #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #183 |
mysurvive
changed the title
xyzzy42
reviewed
Jan 5, 2025
Comment on lines
-147
to
+157
| if (e === n.exceptions[n.exceptions.length - 1]) { | ||
| s = s + `${e}`; | ||
| const bypassable = e.label ? game.i18n.localize(e.label) : e; | ||
| if (n.exceptions.length === 1) { | ||
| s = s + `${bypassable}`; | ||
| } else { | ||
| s = s + `${e}, `; | ||
| s = s + `${bypassable}, `; |
There was a problem hiding this comment.
This adds a trailing comma if there are multiple exceptions:
The join() method is an easy way to just add commas between items:
s += n.exceptions.map(e => e.label ? game.i18n.localize(e.label) : e).join(', ');There was a problem hiding this comment.
I see the system IWR object has some labels already, I wonder if it might be easier to just use those everywhere? They don't look quite as nice as the ones with more html markup created for the earlier part of the EV dialog, but it would save a lot of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes some of the logic in breached defenses to compensate for complex resistance exceptions, such as the Vampire Count's physical resistance (except magical silver).
Complex resistance exceptions are not set up the same way as simple resistance exceptions, so there's quite a bit more digging into the object to find what we need to add all of the proper rule elements to the Breached Defenses effect. This also fixes the dialog box's incorrect "except [object object]" lines that were produced for complex exceptions.
There is still an issue with the Adamantine Golem - it looks like the vorpal rune isn't part of the IWR calculation during a strike... which makes sense since runes are not fully implemented yet. Either way, this solution also handles that problem in the future (why is it ['vorpal-adamantine'] instead of ['vorpal', 'adamantine']????) when runes are implemented.