Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid looping forever when hook is called with unchanged_cert #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bscattergood
Copy link

Ubuntu 18.04 has dehydrated 0.6.1 in the default repositories.

When running "dehydrated -c" and there are no certificates to update,
that calls the hook with "unchanged_cert" and 5 additional parameters.

The hook script then hangs (as it will when run when the number of
arguments isn't a multiple of 3), since "$1" is not empty, but "shift
3" fails and leaves the arguments alone.

Avoid this by checking if "$3" is empty instead.

Ubuntu 18.04 has dehydrated 0.6.1 in the default repositories.

When running "dehydrated -c" and there are no certificates to update,
that calls the hook with "unchanged_cert" and 5 additional parameters.

The hook script then hangs (as it will when run when the number of
arguments isn't a multiple of 3), since "$1" is not empty, but "shift
3" fails and leaves the arguments alone.

Avoid this by checking if "$3" is empty instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant