Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add multiple accounts support #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ayyess
Copy link

@ayyess ayyess commented Nov 20, 2016

A solution to issue #71 where calendars on different google accounts can't be synced at the same time because they have different access tokens.

org-gcal-token-plist has been renamed to org-gcal-tokens-plist and contains each calendars plist. The calendar's url is used as the key.
Each calendars plist is also saved in separate files i.e.(concat org-gcal-token-file calendar-url)
All the (plist-get org-gcal-tokens-plist calendar-url) calls can be cleaned up.

@j-martin
Copy link

j-martin commented Jan 8, 2017

Confirming this PR works great with multiple accounts on different domains / GSuite accounts.

@andjscott do you think it should be ok to remove the [WIP] tag/tilte?

@ayyess
Copy link
Author

ayyess commented Jan 8, 2017

I'm glad it works for you. I originally put the WIP in the title because emacs seemed to repeatedly write to the files holding the token for each account and didn't find the cause.
I can't remove the WIP from the title but won't mind if a repo admin can and wants to change it.

@blarghmatey
Copy link

I manually applied this patch and resolved the conflicts and can confirm that it is working wonderfully for me as well. It would be awesome if we can get the merged into the project. @andyjscott would it be possible for you to resolve the merge conflict so that @myuhe can more easily accept this patch?

Thanks to everyone for this project!

blarghmatey pushed a commit to blarghmatey/org-gcal.el that referenced this pull request Sep 12, 2017
Applied the patch from myuhe#72 to
enable support for multiple Google accounts.
@ayyess
Copy link
Author

ayyess commented Sep 12, 2017

I've merged the master branch into this branch but haven't tested the *-at-point functions or looked at this code for a while so let me know how you get on.

@blarghmatey
Copy link

Thanks!

@bobberb
Copy link

bobberb commented Jan 24, 2018

@andyjscott are -at-point function still not working in your branch ?

@bqv
Copy link

bqv commented Jun 8, 2019

@myuhe reminder that this exists and should be merged

@bobberb
Copy link

bobberb commented Jun 8, 2019

@bqv

The community left this repo for

https://github.com/kidd/org-gcal.el/

And that repo is what MELPA currently references

@telotortium
Copy link

Hi everyone! This repository is obsolete - the actively developed fork is now https://github.com/kidd/org-gcal.el, which is also the "org-gcal.el" on MELPA (see #115). I'm one of the maintainers of https://github.com/kidd/org-gcal.el. I can't directly close issues or PRs on this repo, but please download https://github.com/kidd/org-gcal.el and see if your issue or PR is still applicable. If so, open an issue or PR on https://github.com/kidd/org-gcal.el. In any case, you should close your issue or PR in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants