Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: introduce explicit error handling #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat!: introduce explicit error handling #3

wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Dec 13, 2024 •
edited
Loading

Description

Introduces an explicit Error, instead of using anyhow
Also removes an unused dependency time

Ref n0-computer/iroh#2741

Breaking Changes

Functions do not return anyhow::Error, but std::io::Error or iroh_metrics::Error now.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@dignifiedquire dignifiedquire requested a review from Arqu December 13, 2024 19:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-metrics/pr/3/docs/iroh_gossip/

Last updated: 2024-12-13T19:11:56Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arqu Arqu Awaiting requested review from Arqu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dignifiedquire