Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unify hex encoding with data-encoding #3047

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: unify hex encoding with data-encoding #3047

wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Dec 13, 2024 •
edited
Loading

Description

We already use data-encoding for base32 and hex encoding, this replaces our usage of the hex crate with this.

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@dignifiedquire dignifiedquire requested a review from a team December 13, 2024 18:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3047/docs/iroh/

Last updated: 2024-12-13T18:30:05Z

@github-actions GitHub Actions
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: c8bc0bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
iroh
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dignifiedquire