-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Django to version 4.2.x with Python 3.9 #321
base: master
Are you sure you want to change the base?
Conversation
This pull request fixes 3 alerts when merging 9035f1d into 4012a0d - view on LGTM.com fixed alerts:
|
This pull request fixes 3 alerts when merging d94d8ae into 4012a0d - view on LGTM.com fixed alerts:
|
Unless I'm mistaken, if we merge this we will break deployed Nabaztags running pynab on Buster (almost everyone except some power users). So we probably should make this PR a draft until we have a working Buster to Bullseye migration procedure. |
This should not break since this still installs Django 3.2.x if Python 3.7 (e.g. Buster); Django 4.2.x is installed only if Python 3.9 (e.g. Bullseye). |
Nice, didn't look deep enough. |
Hence my cautious note above that this PR might be suitable only when Pynab drops support for Raspbian (Buster) altogether. |
This pull request fixes 3 alerts when merging 39dc94a into 814b6e1 - view on LGTM.com fixed alerts:
|
This pull request fixes 3 alerts when merging e7f6b80 into d869ca7 - view on LGTM.com fixed alerts:
|
This pull request fixes 2 alerts when merging a0664fb into 629a061 - view on LGTM.com fixed alerts:
|
cafead1
to
f24c384
Compare
Note: zero_raspios and zero2_64_raspios checks will fail till PR #455 is successfully merged. |
c3a0ee7
to
e1a23b1
Compare
Bump Django to version
4.2.x
with Python3.9
.Note: Django 4.x drops support for Python 3.7 (and hence Buster). So Django 3.2.x is still used with Python 3.7.
Some other requirements also bumped for security fixes.
Note:
snips-nlu 0.20.2.1 depends on future<0.18 and >=0.16