Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMTP compliance, custom EHLO hostname #664

Merged
merged 3 commits into from
Dec 26, 2024
Merged

SMTP compliance, custom EHLO hostname #664

merged 3 commits into from
Dec 26, 2024

Conversation

mxsasha
Copy link
Contributor

@mxsasha mxsasha commented Oct 8, 2024

This PR has a tiny doc fix, and two changes to SMTP:

  • SMTP EHLO hostname is configurable. Some mail servers seem to look at this for anti spam protection. Previously in Add support for custom SMTP EHLO hostname #636.
  • SMTP interaction now uses smtplib.SMTP (from Python stdlib) for interacting with the server. The old implementation was very crude, and did not understand multi line responses, effectively used pipelining without negotiating it, and had some other issues. The new code also has some improvement in error messages.

@mxsasha mxsasha force-pushed the smtp-improvements branch 2 times, most recently from ed618e2 to 2903e2b Compare October 8, 2024 10:10
@mxsasha
Switch to smtplib.SMTP for more compliant SMTP handling
01ca04d 
The current "client" did not wait for the greeting to finish before
sending commands, and took some other liberties with the SMTP standard.
This causes issues with some servers.
@mxsasha mxsasha force-pushed the smtp-improvements branch from 2903e2b to 01ca04d Compare October 8, 2024 10:33
@nabla-c0d3 nabla-c0d3 changed the base branch from release to dev December 26, 2024 16:51
@nabla-c0d3 nabla-c0d3 mentioned this pull request Dec 26, 2024
Merged
@nabla-c0d3 nabla-c0d3 merged commit 3e0015c into nabla-c0d3:dev Dec 26, 2024
10 of 11 checks passed
@nabla-c0d3
Copy link
Owner

nabla-c0d3 commented Dec 26, 2024 •
edited
Loading

Thank you ! This was merged as part of #682 . Using the SMTP module seems like a nice approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxsasha @nabla-c0d3