Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local names for some Puerto Rico, Dominican Republic, and El Salvador holidays #712

Merged
merged 1 commit into from
Nov 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/Nager.Date/HolidayProviders/DominicanRepublicHolidayProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,56 +31,56 @@ protected override IEnumerable<HolidaySpecification> GetHolidaySpecifications(in
{
Date = new DateTime(year, 1, 1),
EnglishName = "New Year's Day",
LocalName = "New Year's Day",
LocalName = "Día de Año Nuevo",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 1, 6),
EnglishName = "Day of Kings",
LocalName = "Dia de Reyes",
LocalName = "Día de Reyes",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 1, 21),
EnglishName = "Our Lady of Altagracia",
LocalName = "Our Lady of Altagracia",
LocalName = "Día de Nuestra Señora de la Altagracia",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 1, 26),
EnglishName = "Duarte's Birthday",
LocalName = "Duarte's Birthday",
LocalName = "Día del Natalicio de Juan Pablo Duarte",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 2, 27),
EnglishName = "Independence Day",
LocalName = "Independence Day",
LocalName = "Día de la Independencia de la República Dominicana",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 5, 1),
EnglishName = "Labour Day",
LocalName = "Labour Day",
LocalName = "Día del Trabajador",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 5, 28),
EnglishName = "Mother's Day",
LocalName = "Mother's Day",
LocalName = "Día de las Madres",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 8, 16),
EnglishName = "Restoration Day",
LocalName = "Restoration Day",
LocalName = "Día de la Restauración Dominicana",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
Expand All @@ -94,14 +94,14 @@ protected override IEnumerable<HolidaySpecification> GetHolidaySpecifications(in
{
Date = new DateTime(year, 11, 6),
EnglishName = "Constitution Day",
LocalName = "Constitution Day",
LocalName = "Día de la Constitución",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 12, 25),
EnglishName = "Christmas Day",
LocalName = "Christmas Day",
LocalName = "Navidad",
HolidayTypes = HolidayTypes.Public
},
this._catholicProvider.GoodFriday("Good Friday", year),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ protected override IEnumerable<HolidaySpecification> GetHolidaySpecifications(in
{
Date = new DateTime(year, 5, 1),
EnglishName = "Labor Day",
LocalName = "Día del trabajo",
LocalName = "Día del Trabajo",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
Expand Down
4 changes: 2 additions & 2 deletions src/Nager.Date/HolidayProviders/PuertoRicoHolidayProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,14 @@ protected override IEnumerable<HolidaySpecification> GetHolidaySpecifications(in
{
Date = secondMondayInOctober,
EnglishName = "Columbus Day",
LocalName = "Día de la Raza Descubrimiento de América",
LocalName = "Día de la Raza / Descubrimiento de América",
HolidayTypes = HolidayTypes.Public
},
new HolidaySpecification
{
Date = new DateTime(year, 11, 11),
EnglishName = "Veterans Day",
LocalName = "Día del Veterano Día del Armisticio",
LocalName = "Día del Veterano / Día del Armisticio",
HolidayTypes = HolidayTypes.Public,
ObservedRuleSet = observedRuleSet
},
Expand Down