Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Landing Page Redesign #84

Merged
merged 15 commits into from
May 20, 2024
Merged

[WIP] Landing Page Redesign #84

merged 15 commits into from
May 20, 2024

Conversation

Annastacia-dev
Copy link
Contributor

@Annastacia-dev Annastacia-dev commented Apr 16, 2024 •
edited
Loading

What

Redesign some sections of the landing page.
Refactor code for some sections of the landing page.
Restyle( increase some margins and spacings)

Screenshots

Screenshot from 2024-05-16 13-33-54
Screenshot from 2024-05-16 13-33-24

@Annastacia-dev Annastacia-dev changed the title [ Work In Progress ] Landing Page Redesign [WIP] Landing Page Redesign Apr 16, 2024
@JudahSan
Copy link
Collaborator

Props for improving the design @Annastacia-dev
Kindly fix the conflicting files

@JudahSan JudahSan requested review from banta and denissellu April 18, 2024 21:55
@JudahSan JudahSan added the enhancement New feature or request label Apr 18, 2024
@Annastacia-dev
Copy link
Contributor Author

Props for improving the design @Annastacia-dev Kindly fix the conflicting files

Hello, the PR is still a work in progress will fix and also let you know when it's ready for review, let's hold on that

@Annastacia-dev
Copy link
Contributor Author

Annastacia-dev commented May 16, 2024 •
edited
Loading

@JudahSan the PR is ready for review

JudahSan
JudahSan requested changes May 16, 2024
View reviewed changes
app/views/layouts/_navbar.html.erb Outdated Show resolved Hide resolved
@JudahSan
Copy link
Collaborator

@JudahSan the PR is ready for review

Reviewed. Nice work.

@JudahSan JudahSan removed request for banta and denissellu May 16, 2024 14:55
@denissellu
Copy link
Collaborator

denissellu commented May 16, 2024 •
edited
Loading

@Annastacia-dev this is great work! thanks!

I love that you are bring in annotate! 👏

how would you feel to cherry-pick it in to another PR? this commit? 63a113f
it'll help make review easier and keep this PR focused on the design changes

denissellu
denissellu requested changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@denissellu denissellu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Annastacia-dev thanks for the work on here!

just small changes to move the arrays create in the partials into helpers, so the templates can be tidier and easier to manage.

what do you think?

app/views/landing/home/_activities.html.erb Outdated Show resolved Hide resolved
app/views/landing/home/_chapters.html.erb Outdated Show resolved Hide resolved
app/views/landing/home/_featured_sponsors.html.erb Outdated Show resolved Hide resolved
app/views/landing/home/_previous_sponsors.html.erb Outdated Show resolved Hide resolved
app/views/layouts/_footer.html.erb Outdated Show resolved Hide resolved
@Annastacia-dev Annastacia-dev requested a review from denissellu May 16, 2024 17:50
@Annastacia-dev Annastacia-dev requested a review from JudahSan May 16, 2024 17:50
denissellu
denissellu approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@denissellu denissellu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 nice one!

@JudahSan JudahSan merged commit 92c452d into nairuby:main May 20, 2024
2 checks passed
@Annastacia-dev Annastacia-dev mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JudahSan JudahSan JudahSan approved these changes

@denissellu denissellu denissellu approved these changes

Assignees

@Annastacia-dev Annastacia-dev

Labels
enhancement New feature or request
Projects
arc_platform backlog
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Annastacia-dev @JudahSan @denissellu