Added the nonMilitaryTime format support with a new format #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H e HH --> 24 Hours h e hh --> 12 hours tt --> AM e PM new nonMilitaryTime format example: M/d/yyyy h:mm tt old format example: dd/MM/yyyy HH:mm
jflow1127
reviewed
May 6, 2020
| @@ -1359,17 +1367,20 @@ | |||
| return ''; | |||
| } | |||
| var val = { | |||
| h: date.getUTCHours(), | |||
| H: date.getUTCHours(), | |||
| h: date.getUTCHours() % 12, | |||
There was a problem hiding this comment.
@mbellet You will want to check date.getUTCHours == 0 this indicates 12:00 AM. right now when you select 12:00 am it displays as 00:00 AM.
Possible solution is:
h: (date.getUTCHours() == 0) ? 12 : date.getUTCHours() % 12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the nonMilitaryTime format support with this new format:
H e HH --> 24 Hours
h e hh --> 12 hours
tt --> AM e PM
new nonMilitaryTime format example: M/d/yyyy h:mm tt
old format example: dd/MM/yyyy HH:mm