(WIP) Overhauled the Buy Names Page with the Electrum-NMC version #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error boxes for invalid names. There are still multiple bugs which lead to crashes, so filing a PR as WIP for now.
JeremyRand
reviewed
Nov 18, 2024
| @@ -153,5 +394,6 @@ | |||
| <resources> | |||
| <include location="../bitcoin.qrc"/> | |||
| </resources> | |||
| <resources/> | |||
There was a problem hiding this comment.
This is an Electrum-ism, we already have a (non-empty) resources element (above).
|
OK so initial reaction: the XML form changes here are really hard to review because there's too much happening in a single commit. For example, the text I think one way to improve this would be to split the XML form diff into two commits: one that exclusively tweaks whitespace on existing lines, and one that adds/removes lines. This should make it a lot easier for Git to tell which lines correspond in the diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauled the Buy Names Page with the Electrum-NMC version and added error boxes for invalid domain names. There are still multiple bugs which lead to crashes, so filing a PR as WIP for now.