Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update grcov to latest stable version #27

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

pulsastrix
Copy link
Member

The new stable release of grcov fixes the compilation issue related to the time crate, which we previously worked around by pulling in the branch from mozilla/grcov#1191.

Therefore, our previous workaround is no longer necessary, and we can use the stable version again.

@pulsastrix pulsastrix requested a review from falko17 November 20, 2024 13:13
@pulsastrix pulsastrix self-assigned this Nov 20, 2024
@pulsastrix pulsastrix added this to the Version 0.5 milestone Nov 20, 2024
@falko17
Copy link
Member

falko17 commented Nov 20, 2024

PR itself is good to go, but for some reason the test_coverage CI is failing now.

@pulsastrix
Copy link
Member Author

Apparently, the -Zprofile unstable flag has been removed, see rust-lang/rust#131829 and the feature's tracking issue rust-lang/rust#42524.

The (stable) replacement seems to be the instrument-coverage flag, I'll have a look at the required changes to get our pipeline working again using this flag.

@coveralls
Copy link

coveralls commented Nov 20, 2024

Coverage Status

coverage: 86.555% (+1.3%) from 85.242%
when pulling d2b3d70 on ci_update_grcov
into 3832486 on main.

The new stable release of grcov fixes the compilation issue related to
the `time` crate, which we previously worked around by pulling in the
branch from [PR 1191](mozilla/grcov#1191).

Therefore, our previous workaround is no longer necessary, and we can
use the stable version again.
@pulsastrix
Copy link
Member Author

The pipeline is now switched over to using the newer (and stable) -C instrument-coverage flag, which enables source-based coverage reports.

For future reference, see:

@pulsastrix pulsastrix merged commit 63ddc42 into main Nov 20, 2024
10 checks passed
@pulsastrix pulsastrix deleted the ci_update_grcov branch November 20, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants