Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SynProxy #29

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Implement SynProxy #29

merged 3 commits into from
Oct 21, 2024

Conversation

jwhb
Copy link
Member

@jwhb jwhb commented Mar 18, 2024

SynProxy was missing, as it is not mentioned in the libnftables-json man page.

A few other statements were found to be implement in libnftables-json while not being documented by libnftables. TODO marks have been added for these statements.

Fixes #15.

@jwhb jwhb added the enhancement New feature or request label Mar 18, 2024
@jwhb jwhb changed the title SynProxy support Implement SynProxy Oct 19, 2024
@jwhb jwhb marked this pull request as ready for review October 19, 2024 16:09
@jwhb jwhb requested a review from JKRhb October 19, 2024 16:09
@jwhb jwhb added this to the v0.5.0 milestone Oct 19, 2024
@jwhb jwhb mentioned this pull request Oct 19, 2024
Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See a couple of comments below :)

src/stmt.rs Show resolved Hide resolved
src/stmt.rs Show resolved Hide resolved
src/stmt.rs Show resolved Hide resolved
src/schema.rs Outdated Show resolved Hide resolved
src/schema.rs Show resolved Hide resolved
Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@jwhb jwhb merged commit 94a467b into namib-project:main Oct 21, 2024
4 checks passed
@jwhb jwhb deleted the synproxy branch October 21, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json schema is missing synproxy support
2 participants