Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Don't need to calculate cdf with np.where to plot p-p plot #26

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vhaasteren
Copy link
Member

Don't merge this yet, I first want to have the discussion.

I've been wondering about the following. When making a p-p plot, la forge and some other packages I've seen calculate the cdf by counting realizations with up to a certain p-value. But the p-value is supposed to be distributed according to Uniform(0, 1). That means you can just straight up plot p-value vs q. Compared to the 'counting' way, this means you have slightly more independent datapoins in the p-p plot.

See what I mean at the code diff below. The difference is very minimal, but it's more elegant.

Is there a reason not to be changing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant