Improve deploy workflow by use deploy directory from workflow dispatch input #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jni
reviewed
Aug 13, 2024
| target_directory: | ||
| description: 'The directory to deploy the docs to' | ||
| required: true | ||
| default: 'dev' |
There was a problem hiding this comment.
@Czaki one question here — what happens when you trigger manually? You get a small text field to fill in?
There was a problem hiding this comment.
Yes. You may play with the benchmark workflow on the main repo.
|
I think this is ready to go, starting the clock if there are no objections. |
jni
pushed a commit
to napari/napari
that referenced
this pull request
Aug 29, 2024
# References and relevant issues requires napari/docs#477 # Description Calculate deploy directory based on ref and pass it to called workflow using inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Description
As
convictional/trigger-workflow-and-waitdo not pass proper reference to workflow, this PR changed to use workflow dispatch input. This will allow triggering deploy docs manually to a given directory without the need to create a tag.