Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 0.5.2+ #232

Closed
wants to merge 1 commit into from
Closed

Fix for 0.5.2+ #232

wants to merge 1 commit into from

Conversation

Czaki
Copy link
Contributor

@Czaki Czaki commented Sep 5, 2024

This PR is pointing place where animation code depends on events order.

After this fix, the code will, work with 0.5.2 but not earlier.

Closes #231

The alternative is to use `position='first`` when connecting event. But code that do not depend on callback order may be better.

@Czaki Czaki marked this pull request as draft September 5, 2024 21:50
@Czaki Czaki changed the title Fix for 0.5.3 Fix for 0.5.2+ Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.24%. Comparing base (ba8ab53) to head (e058377).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          26       26           
  Lines        1076     1076           
=======================================
  Hits          928      928           
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psobolewskiPhD
Copy link
Member

psobolewskiPhD commented Sep 5, 2024

I don't like restricting napari version...
I tried adding the position kwarg in those connect in the __init__ but that didn't work.
Here's what I came up with:
#233

It's breaking in that it removes the insert kwarg for updating in-place that was triggering the bug.

@Czaki Czaki deleted the fix_0_5_3 branch September 6, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacing keyframes breaks keyframe list
2 participants