Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installer infra to catch up with upstream (part two) #49

Merged
merged 8 commits into from
Dec 13, 2022

Conversation

jaimergp
Copy link
Collaborator

@jaimergp jaimergp commented Dec 5, 2022

Continues work started in #42, part of #15

@jaimergp
Copy link
Collaborator Author

jaimergp commented Dec 8, 2022

Updates to bundle_tools_2 complete.

@jaimergp jaimergp marked this pull request as ready for review December 8, 2022 16:36
@jaimergp
Copy link
Collaborator Author

jaimergp commented Dec 8, 2022

Most of the changes involved in this new series didn't happen in this feedstock, but in other repos as mentioned in #15 (comment)

Summary of changes:

  • Support for MacOS permission system
  • Support for elevation on Windows
  • Find base_prefix more robustly
  • Add python interface to conda-standalone

@jaimergp jaimergp linked an issue Dec 8, 2022 that may be closed by this pull request
altool is deprecated and the actions we were using are archived now
@liu-ziyang
Copy link
Contributor

going to merge this in 24 hours

@jaimergp
Copy link
Collaborator Author

Thanks.

Note we changed how notarization works because the tool we were using (altool) is going to be deprecated by Apple and the actions we used are now archived and unmaintained. Fun fact: this was reported by the Anaconda team working on using our constructor improvements :)

This should be more reliable, but we need to test it in a run where the secrets are available.

So yes, let's merge to not block QA but I might need to adjust a couple details in a further PR.

@liu-ziyang liu-ziyang merged commit 49013e2 into main Dec 13, 2022
@liu-ziyang liu-ziyang deleted the update-recipe-2 branch December 13, 2022 16:16
@Carreau
Copy link

Carreau commented Dec 14, 2022

Is there anything I ca do to help test this ? In particular I have a mac with an apple arm64 chip if that helps.

@jaimergp
Copy link
Collaborator Author

We need to check the notarization steps, running here napari/napari#5411

Once we have some artifacts, we can QA whether the installer throws warnings, shortcuts are created, etc. I'll ping you in the other PR once they are ready, @Carreau. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PermissionsError when accessing some directories with os module
3 participants