Skip to content

Commit

Permalink
Catch specific exceptions in Herschel_get_spec (#294)
Browse files Browse the repository at this point in the history
* catch specific exceptions

* update comment from jkrick review f16c102
  • Loading branch information
troyraen committed Aug 2, 2024
1 parent c24e43e commit 77afd6e
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 4 deletions.
Binary file modified .doctrees/documentation/notebook_review_process.doctree
Binary file not shown.
Binary file modified .doctrees/environment.pickle
Binary file not shown.
Binary file modified .doctrees/spectroscopy/spectra_generator.doctree
Binary file not shown.
6 changes: 5 additions & 1 deletion _sources/documentation/notebook_review_process.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ For authors: consider these checklists requirements for your code.
- Is every function documented?
- Does it follow the style guide? https://github.com/spacetelescope/style-guides/blob/master/guides/jupyter-notebooks.md
- Do all code cells have corresponding narratives/comments?
- Include information about runtime on fiducial Fornax server
- Include information about which "image" the notebook uses when loggin into Fornax, ie., "Astrophysics default image"
- Notebook execution, error handling, etc.:
- Does the notebook run end-to-end, out of the box?
- Are errors handled appropriately, with `try`/`except` statements that are narrow in scope?
Expand All @@ -38,7 +40,9 @@ For authors: consider these checklists requirements for your code.
- Cleanup:
- Have blocks of code that need to be re-used been turned into functions (rather than being duplicated)?
- Have un-used libraries been removed from the requirements.txt file and the `import` statements?
- Has un-used code been removed (e.g., unused functions and commented-out lines)?
- Has un-used code been removed (e.g., unused functions and commented-out lines)?
- Are comment lines wrapped so all fit within a max of 90 - 100 characters per line?
- Are code lines reasonably short where possible? some code lines can't easily be wrapped and that is ok

```python

Expand Down
2 changes: 1 addition & 1 deletion _sources/spectroscopy/spectra_generator.md
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ df_spec.append(df_spec_HST)
### 2.3 ESA Archive
```python
# Herschel PACS & SPIRE from ESA TAP using astroquery
#This search is fully functional, but is commented out because it is very slow.
#This search is fully functional, but is commented out because it takes ~4 hours to run to completion
herschel_radius = 1.1
herschel_download_directory = 'data/herschel'

Expand Down
4 changes: 4 additions & 0 deletions documentation/notebook_review_process.html
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,8 @@ <h2>Tech Review Checklist<a class="headerlink" href="#tech-review-checklist" tit
<li><p>Is every function documented?</p></li>
<li><p>Does it follow the style guide? https://github.com/spacetelescope/style-guides/blob/master/guides/jupyter-notebooks.md</p></li>
<li><p>Do all code cells have corresponding narratives/comments?</p></li>
<li><p>Include information about runtime on fiducial Fornax server</p></li>
<li><p>Include information about which “image” the notebook uses when loggin into Fornax, ie., “Astrophysics default image”</p></li>
</ul>
</li>
<li><p>Notebook execution, error handling, etc.:</p>
Expand All @@ -484,6 +486,8 @@ <h2>Tech Review Checklist<a class="headerlink" href="#tech-review-checklist" tit
<li><p>Have blocks of code that need to be re-used been turned into functions (rather than being duplicated)?</p></li>
<li><p>Have un-used libraries been removed from the requirements.txt file and the <code class="docutils literal notranslate"><span class="pre">import</span></code> statements?</p></li>
<li><p>Has un-used code been removed (e.g., unused functions and commented-out lines)?</p></li>
<li><p>Are comment lines wrapped so all fit within a max of 90 - 100 characters per line?</p></li>
<li><p>Are code lines reasonably short where possible? some code lines can’t easily be wrapped and that is ok</p></li>
</ul>
</li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion searchindex.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion spectroscopy/spectra_generator.html
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,7 @@ <h3>2.2 MAST Archive<a class="headerlink" href="#mast-archive" title="Link to th
<section id="esa-archive">
<h3>2.3 ESA Archive<a class="headerlink" href="#esa-archive" title="Link to this heading">#</a></h3>
<div class="highlight-python notranslate"><div class="highlight"><pre><span></span><span class="c1"># Herschel PACS &amp; SPIRE from ESA TAP using astroquery</span>
<span class="c1">#This search is fully functional, but is commented out because it is very slow.</span>
<span class="c1">#This search is fully functional, but is commented out because it takes ~4 hours to run to completion</span>
<span class="n">herschel_radius</span> <span class="o">=</span> <span class="mf">1.1</span>
<span class="n">herschel_download_directory</span> <span class="o">=</span> <span class="s1">&#39;data/herschel&#39;</span>

Expand Down

0 comments on commit 77afd6e

Please sign in to comment.