commenting out herschel #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
approved these changes
Jul 25, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
commenting out herschel a3aa90c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last PR seems to have been empty...trying again to do the same thing...
super small PR to
In the SP meeting Jul/24 we decided that this module is functional but too slow to include. We will leave it commented out in the notebook so that CI/CD can run, and people can use it if they like, but the whole notebook will not be slowed down by the herschel archive.