[nasa/cryptolib#379] Updated to gcc-14 for MC/DC #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #381 +/- ##
==========================================
- Coverage 76.53% 75.97% -0.57%
==========================================
Files 81 81
Lines 22041 22263 +222
Branches 1777 1807 +30
==========================================
+ Hits 16870 16914 +44
- Misses 4531 4707 +176
- Partials 640 642 +2 ☔ View full report in Codecov by Sentry. |
Donnie-Ice
changed the title
Donnie-Ice
changed the title
|
Had to restore functionality to CI. The docker file is written for gcc/gcov-14 to work with MCDC. It is being used by CodeQL and [#258], but the build.yml is still using the old docker file in dev. |
jlucas9
approved these changes
Jan 6, 2025
jlucas9
reviewed
Jan 6, 2025
support/Dockerfile
Outdated
| @@ -17,19 +17,21 @@ | |||
| # | |||
|
|
|||
| ARG WOLFSSL_VERSION=5.6.0-stable | |||
| FROM ubuntu:jammy-20240530 AS cl0 | |||
| FROM ubuntu:latest AS cl0 | |||
There was a problem hiding this comment.
Can we lock this to whatever the latest actual release is?
rjbrown2
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for CAP MC/DC