Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDSC-3073: Fix 508 compliance 'form control has no name' #1396

Closed
wants to merge 12 commits into from

Conversation

Chauncy-S
Copy link
Contributor

Overview

What is the feature?

Please summarize the feature or fix.

What is the Solution?

Summarize what you changed.

  • In order to solve this problem:
    • I added a label for the preferences Form element within PreferencesFrom.js
    • I added a Legend element to the fieldset element within ContactInfo.js
    • I added a label for the subscriptions list, download history, and saved projects Table element within SubscriptionsList.js, DownloadHistory.js, and SavedProjects.js

What areas of the application does this impact?

List impacted areas.

  • earthdata-search/static/src/js/components/Preferences/
  • earthdata-search/static/src/js/components/ContactInfo
  • earthdata-search/static/src/js/components/DownloadHistory
  • earthdata-search/static/src/js/components/SavedProjects
  • earthdata-search/static/src/js/components/SubscriptionsList

Testing

Reproduction steps

  • Environment for testing:
  • Collection to test with:
  1. Step 1
  2. Step 2...

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

  • [ n/a] I have added automated tests that prove my fix is effective or that my feature works
  • [Y] New and existing unit tests pass locally with my changes
  • [Y] I have performed a self-review of my own code
  • [Y] I have commented my code, particularly in hard-to-understand areas
  • [ n/a] I have made corresponding changes to the documentation
  • [N ] My changes generate no new warnings

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #1396 (f2af2a7) into master (147a63e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1396   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files         655      655           
  Lines       16002    16002           
  Branches     3817     3817           
=======================================
  Hits        14239    14239           
  Misses       1540     1540           
  Partials      223      223           
Impacted Files Coverage Δ
...tatic/src/js/components/ContactInfo/ContactInfo.js 100.00% <ø> (ø)
...c/src/js/components/Preferences/PreferencesForm.js 80.00% <ø> (ø)
...c/js/components/DownloadHistory/DownloadHistory.js 100.00% <100.00%> (ø)
...c/src/js/components/SavedProjects/SavedProjects.js 97.22% <100.00%> (ø)
.../components/SubscriptionsList/SubscriptionsList.js 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147a63e...f2af2a7. Read the comment docs.

@macrouch macrouch closed this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants