fix None type check and assert number

nasa · Jan 2, 2025 · d6710a6 · d6710a6
1 parent 9304bd0
commit d6710a6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/ncompare/getters.py b/ncompare/getters.py
@@ -78,13 +78,17 @@ def get_subgroups(node: Union[netCDF4.Dataset, netCDF4.Group, h5py.Group], file_
 
     Returns
     -------
-    list
+    list or None
         subgroups under the node
     """
-    if file_type == "hdf5":
+    if node is None:
+        return []
+    elif file_type == "hdf5":
         return [key for key in node.keys() if isinstance(node[key], h5py.Group)]
-    else:  # should be "netcdf"
+    elif file_type == "netcdf":  # should be "netcdf"
         return list(node.groups)
+    else:
+        return []
 
 
 def get_variables(node: Union[netCDF4.Dataset, netCDF4.Group, h5py.Group], file_type: str) -> list:

diff --git a/tests/test_core.py b/tests/test_core.py
@@ -84,4 +84,4 @@ def test_icesat(temp_data_dir):
         file_text=str(out_path),
     )
 
-    assert num_differences == 4982
+    assert num_differences == 5280